Move verification tests into this repo #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
verif-move
branch
4 times, most recently
from
af8a40e to
4b5410f
Compare
| @@ -39,6 +39,11 @@ allprojects { | |||
| } | |||
| } | |||
|
|
|||
| buildscript { | |||
| // required for m1 mac | |||
| configurations { classpath { resolutionStrategy { force("net.java.dev.jna:jna:5.7.0") } } } | |||
There was a problem hiding this comment.
@tillrohrmann can you double check this? I don't remember you ever needed this
There was a problem hiding this comment.
Need this fix in 5.7.0 java-native-access/jna#1238
There was a problem hiding this comment.
That's quite an old bug, i wonder which dep is bringing this in
There was a problem hiding this comment.
its this thing which is unmaintained https://github.com/JetBrains/intellij-deps-trove4j
There was a problem hiding this comment.
| +--- org.jetbrains.kotlin:kotlin-compiler-embeddable:1.8.10
| | +--- org.jetbrains.kotlin:kotlin-daemon-embeddable:1.8.10
| | +--- org.jetbrains.intellij.deps:trove4j:1.0.20200330
| | \--- net.java.dev.jna:jna:5.6.0 -> 5.7.0
There was a problem hiding this comment.
Uh ok i'll try to see if this goes away when bumping kotlin
slinkydeveloper
approved these changes
May 31, 2023
Comment on lines
+22
to
+23
| # Use a new stage so that the build-arg GH_PACKAGE_READ_ACCESS_TOKEN isn't leaked into the final image history | ||
| COPY --from=prod /usr/src/app/ /usr/src/app/ |
There was a problem hiding this comment.
Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122